Skip to content

Conversation

@radium-v
Copy link
Collaborator

@radium-v radium-v commented Oct 19, 2025

Pull Request

📖 Description

This PR switches the test fixtures in the FAST HTML package from Webpack to Vite. Instead of building each fixture as its own config, Vite is able to run all of the fixtures as a multi-page build.

Additionally, this PR fixes dot-syntax tests that were failing around property access in repeats, and cleans up utility types.

👩‍💻 Reviewer Notes

These script commands have changed in the fast-html package:

  • npm run dev: Runs a tsc watcher and vite dev server for @microsoft/fast-html
  • npm run dev:full: Same as dev, and includes an additional tsc watcher for @microsoft/fast-element
  • npm run test:ui: Start the full watcher and open Playwright in UI mode

📑 Test Plan

All tests should pass.

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

⏭ Next Steps

In the future we should switch FAST Element from Karma to Playwright, and migrate other packages from Webpack to Vite.

@radium-v radium-v self-assigned this Oct 20, 2025
chrisdholt
chrisdholt previously approved these changes Oct 29, 2025
@radium-v radium-v force-pushed the users/radium-v/fast-html-test-fixtures branch from 3599594 to 93d2eac Compare October 31, 2025 20:18
@radium-v radium-v requested a review from chrisdholt October 31, 2025 20:26
@radium-v radium-v merged commit 6fdf025 into main Oct 31, 2025
11 checks passed
@radium-v radium-v deleted the users/radium-v/fast-html-test-fixtures branch October 31, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants